Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis@6.2 6.2.7 (new formula) #102258

Closed
wants to merge 1 commit into from
Closed

redis@6.2 6.2.7 (new formula) #102258

wants to merge 1 commit into from

Conversation

JamieEdge
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Redis 7.0, added in #100324, introduces a number of potentially breaking changes. For example, the Go client is not yet fully compatible (redis/go-redis#2082).

This pull request adds a formula for the previous major version based on redis.rb.

@BrewTestBot BrewTestBot added legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core labels May 25, 2022
@SMillerDev
Copy link
Member

Please indicate how this would fill our criteria for versioned formulas (https://docs.brew.sh/Versions) and why we might want to ship an older version?

@cho-m cho-m added the needs response Needs a response from the issue/PR author label May 25, 2022
@JamieEdge
Copy link
Contributor Author

Thanks for taking a look at this pull request.

Redis 7.0 introduces a number of potentially breaking changes, as documented in the release notes. For example, the response structure of an important command for using Redis in clustered mode has changed and hence is not currently compatible with certain clients, such as go-redis/redis which is imported by 3,796 public modules at time of writing.

Redis 6.2 is the previous major.minor version and still receives maintenance updates as per the Redis release cycle. It is also the latest version supported by Amazon ElastiCache for Redis and Google Cloud Memorystore for Redis at time of writing, so there is a good case aside from the particular breaking change referenced to keep the two previous major.minor versions available in Homebrew so that engineers can run the same version locally as they do remotely.

There are also existing versioned formulae for redis@4.0 and redis@3.2

I've had a read through the list of requirements and believe that this formula meets them, but if there's anything that might have been missed, I'd be happy to provide further details.

@cho-m cho-m removed the needs response Needs a response from the issue/PR author label May 25, 2022
@SMillerDev
Copy link
Member

Looking at the document, can you add a disable! date: "2023-05-27", because: :deprecated_upstream so that it's disabled when Redis drops support for it.

@chenrui333 chenrui333 added the needs response Needs a response from the issue/PR author label Jun 2, 2022
@chenrui333
Copy link
Member

ping @JamieEdge

@JamieEdge
Copy link
Contributor Author

Apologies for the delayed response.

Before committing this change, please could I ask how the disable date would be calculated for this formula? My understanding is that Redis 6.2 will receive maintenance updates until the release of Redis 8.0. I was not able to find a provisional release date for this next major release.

@SMillerDev
Copy link
Member

https://redis.io/docs/about/releases/#release-schedule suggests a major release every year, and a minor release in 6 months. So support will be:

  • now: 7.0, 6.2, 6.0
  • 6 months: 7.1, 7.0, 6.2
  • 1 year: 8.0, 7.1, 7.0

@BrewTestBot BrewTestBot added the formula disabled Formula disabled label Jun 12, 2022
@JamieEdge
Copy link
Contributor Author

Thanks, that makes sense. I have applied all suggestions now.

@BrewTestBot
Copy link
Member

:shipit: @bayandin has triggered a merge.

@bayandin
Copy link
Member

Thanks @JamieEdge! Without contributions like yours, it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
formula disabled Formula disabled legacy Relates to a versioned @ formula needs response Needs a response from the issue/PR author new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants